[fix]: fix the thread leak when suspend#280
Merged
zhongkechen merged 3 commits intomainfrom Mar 27, 2026
Merged
Conversation
zhongkechen
force-pushed
the
localRunner
branch
2 times, most recently
from
ee2deec to
d5ebd0f
Compare
zhongkechen
force-pushed
the
localRunner
branch
from
d5ebd0f to
76fe964
Compare
zhongkechen
force-pushed
the
localRunner
branch
2 times, most recently
from
b925835 to
8bd740b
Compare
zhongkechen
force-pushed
the
localRunner
branch
4 times, most recently
from
f526d93 to
1de6db3
Compare
fix examples prevent Self-suppression not permitted add error message update example for waitforcallback add error messasge add error data add error operations add result
zhongkechen
force-pushed
the
localRunner
branch
from
1de6db3 to
ec0e40d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Issue Link, if available
Description
thread leak
Threads waiting for operations to complete will not be terminated when suspending.
This is because when suspending, the exception is not propagated to the thread waiting for operations to complete.
Fix: mark all open completionFuture completed exceptionally when suspending.
race condition
the parent operation is using completionFuture as the lock while the child operation is using parent operation itself as the lock.
try-with-resource exception
When using try-with-resource with
paralleloperation, if the get() call in the body throws an exception, andclose()of parallel operation throws the same exception, try-with-resource will fail withSelf-suppression not permitted.fix: do not throw the exception in
close()Demo/Screenshots
Checklist
Testing
Unit Tests
Have unit tests been written for these changes?
Integration Tests
Have integration tests been written for these changes?
Examples
Has a new example been added for the change? (if applicable)